Greptile Summary

This PR bumps the 3rdparty/nccl submodule to pick up a downstream fix for MAX_SUPPORTED_TOKENS_PER_RANK, and updates four EP test/bench launcher scripts to use a consistent NVLink detection method.

• Submodule bump (808d2433 → a6b5de08): pulls in the NCCL fix for MAX_SUPPORTED_TOKENS_PER_RANK that affects Expert Parallelism collectives.
• NVLink detection standardized: all four EP scripts now use nvidia-smi nvlink --status 2>/dev/null | grep -qE 'Link [0-9]+:.*GB/s' instead of the topology-matrix check (nvidia-smi topo -m), confirming links are active (showing real bandwidth) rather than merely present in the topology table.
• Three scripts (cpp, jax test, jax bench) gain the NVLink guard for the first time; the PyTorch script replaces the old topology-based guard with the new one.

Confidence Score: 5/5

Safe to merge — the submodule bump is a targeted bug fix and the shell script changes only tighten the existing skip guards.

The only code change is a submodule pointer update and consistent NVLink detection guards across four launcher scripts. The new detection method (checking for active link bandwidth via nvidia-smi nvlink --status) is strictly more precise than the old topology-matrix check, and the worst failure mode is an over-skip on an unusual hardware configuration rather than a hang or data corruption. No TE library code is modified.

No files require special attention.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[EP test/bench script starts] --> B{GPU count >= 4?}
    B -- No --> C[SKIP: not enough GPUs]
    B -- Yes --> D{nvidia-smi nvlink --status\nmatches 'Link N:.*GB/s'?}
    D -- No --> E[SKIP: NVLink not active\nPCIe-only or unsupported]
    D -- Yes --> F[Run EP test / bench]
    F --> G{Exit code == 0?}
    G -- Yes --> H[PASS]
    G -- No --> I[FAIL]

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[EP test/bench script starts] --> B{GPU count >= 4?}
    B -- No --> C[SKIP: not enough GPUs]
    B -- Yes --> D{nvidia-smi nvlink --status\nmatches 'Link N:.*GB/s'?}
    D -- No --> E[SKIP: NVLink not active\nPCIe-only or unsupported]
    D -- Yes --> F[Run EP test / bench]
    F --> G{Exit code == 0?}
    G -- Yes --> H[PASS]
    G -- No --> I[FAIL]

_{Reviews (6): Last reviewed commit: "Detect active NVLink via nvlink --status..." | Re-trigger Greptile}

/te-ci L1

/te-ci L1

Pipeline #56213025

/te-ci L1